Add contributing.md, add goals and principles to the readme #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zephraph
reviewed
Aug 9, 2023
Comment on lines
+6
to
+7
| bugs, we may be able to review and merge them. But be aware that we might not | ||
| get to it for a while, by which time it might no longer be relevant. If you want |
There was a problem hiding this comment.
Suggested change
| bugs, we may be able to review and merge them. But be aware that we might not | |
| get to it for a while, by which time it might no longer be relevant. If you want | |
| bugs, we may be able to review and merge them. But be aware that we might not | |
| get to it for a while or may close it if we don't have the capacity to review it. If you want |
You don't have to accept this suggestion as is. More the idea here is that I think we should be transparent that we may close PRs (even if it's for an arbitrary reason as we don't have the space to deal with this right now and it's cluttering up our queue). Just don't want folks to have the expectation that we will eventually get to their PR b/c we actually may not.
There was a problem hiding this comment.
I think "we may be able to review and merge them" does an ok job of implying that we may not get to it
zephraph
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals and principles might be overdone or underdone, I can't tell.