Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemMbistAggressorsDdr should be an enable/disable token. #143

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

luqmana
Copy link
Contributor

@luqmana luqmana commented Nov 19, 2024

MemMbistAggressorsDdr isn't for selecting the test mode (physical interface vs data eye) but rather for enabling/disabling the MBIST Aggressor tests.

MemMbistAggressorsDdr isn't for selecting the test mode (physical interface vs
data eye) but rather for enabling/disabling the MBIST Aggressor tests.
@luqmana luqmana requested a review from daym November 19, 2024 21:43
@daym
Copy link
Collaborator

daym commented Nov 19, 2024

Whoops. Good catch!

Please also update the (lowest) version in amd-apcb's Cargo.toml .

Please later also update the ahib config files for turin and genoa (others are not affected).

Affected are only:

etc/genoa-ruby-1.0.0.0.efs.json5
etc/genoa-ruby-1.0.0.b.efs.json5
etc/turin-ruby-0.0.7.3.efs.json5
etc/turin-ruby-0.0.8.1.efs.json5
etc/turin-ruby-1.0.0.1-p1.efs.json5
etc/turin-rubyred-0.0.8.1.efs.json5

The raw value was always 0, so should now be "Disabled".

Helios doesn't have a turin ahib config yet--so we are good.

@luqmana luqmana merged commit 839ce4a into main Nov 20, 2024
4 checks passed
@luqmana luqmana deleted the luqmana/mbist-ddr-tokens branch November 20, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants