Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory structs could use slight cleanup #124

Open
daym opened this issue Apr 29, 2024 · 0 comments
Open

Memory structs could use slight cleanup #124

daym opened this issue Apr 29, 2024 · 0 comments
Assignees

Comments

@daym
Copy link
Collaborator

daym commented Apr 29, 2024

We aren't using SODIMMs so I punted on them for the time being. That would be EntryId::Memory(PsSodimmDdr4MaxFreq) and does or does not also use the same struct MaxFreqElement as we already have.

Ddr5CaPinMapElementLane could use some special pin type that marks 0xff as "unused".

I've had some Option0xff<T> user-visible type before and it really wasn't nice to use.

I wonder whether we can have some official special Option where we can choose the representation of the None value.

@daym daym self-assigned this Apr 29, 2024
@daym daym changed the title Memory structs cleanup Memory structs could use slight cleanup Apr 29, 2024
@daym daym mentioned this issue Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant