Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test sdist #109

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Test sdist #109

merged 4 commits into from
Jun 1, 2024

Conversation

tschm
Copy link
Contributor

@tschm tschm commented May 27, 2024

No description provided.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (ed73c9d) to head (13c6667).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          75       75           
  Lines        6011     6011           
=======================================
  Hits         5244     5244           
  Misses        767      767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goulart-paul goulart-paul changed the base branch from main to develop May 28, 2024 18:44
@tschm
Copy link
Contributor Author

tschm commented May 29, 2024

@goulart-paul This I would merge. There is quite some code duplication in pypi.yml and test_pypi.yml. Let's fix them first individually and then "merge" them into one file...

@goulart-paul goulart-paul changed the base branch from develop to main June 1, 2024 09:08
@goulart-paul
Copy link
Member

I am updating these manually to also include names tagged with the os for v4.

You are right that the pypi and testpypi are nearly identical. The testpypi was meant to be temporary when I was changing something else and wanted to try pushing to https://test.pypi.org/ first. It then seemed like a useful thing to keep, but the two should certainly be combined somehow.

@goulart-paul goulart-paul merged commit c1aaf77 into oxfordcontrol:main Jun 1, 2024
12 checks passed
@tschm tschm deleted the patch-2 branch June 2, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants