fix(linter): add option "allowTypeImports" for rule "no-restricted-imports" #7894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Sysix
changed the title
CodSpeed Performance ReportMerging #7894 will not alter performanceComparing Summary
|
… option inside `patterns`
…ld regex in `from_configuration`
…-linter-no-restricted-imports-improve-diagnostics
…nto bugfix-linter-add-option-allow-type-imports-for-no-restricted-imports
Sysix
commented
Jan 3, 2025
| @@ -1832,6 +2600,270 @@ fn test() { | |||
| // ), | |||
| ]; | |||
|
|
|||
| let fail_typescript = vec![ | |||
| ("import foo from 'import1';", Some(serde_json::json!(["import1", "import2"]))), | |||
| // ("import foo = require('import1');", Some(serde_json::json!(["import1", "import2"]))), | |||
There was a problem hiding this comment.
@camc314 should we support this?
Notice the import at the start. There is no entry in ModuleRecord for it.
I searched a bit on the internet and it looks like this is a old syntax.
There is 2 options how to solve this:
- fix
ModuleRecordto implement this use case - loops to the AST nodes and find the require
I am not that good in typescript to understand what the best solution is for the absurd syntax
Boshen
pushed a commit
that referenced
this pull request
Jan 18, 2025
) > The regex property is used to specify the regex patterns for restricting modules. > Note: regex cannot be used in combination with group. _https://eslint.org/docs/latest/rules/no-restricted-imports#regex_ > This option allows you to use regex patterns to restrict import names: _https://eslint.org/docs/latest/rules/no-restricted-imports#importnamepattern_ > This is a string option. Inverse of importNamePattern, this option allows imports that matches the specified regex pattern. So it restricts all imports from a module, except specified allowed patterns. > Note: allowImportNamePattern cannot be used in combination with importNames, importNamePattern or allowImportNames. _https://eslint.org/docs/latest/rules/no-restricted-imports#allowimportnamepattern_ Needed to install `regress` to support JS Sntax like Lookaheads and Lookbehinds Next Goals: - #7894 - Improve spans - Error for wrong configurations - update documentation - Output messages like [eslint](https://github.com/eslint/eslint/blob/main/lib/rules/no-restricted-imports.js#L140-L184)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for #8113