Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] fix tests for reva #10685

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Nov 28, 2024

Description

  • removed duplicate step
    -Then for user :sharee the space Shares should contain these files
    +Then user :sharee should have a share :share shared by user :sharer from space :space
    +Then user :sharee should not have a share :share shared by user :sharer from space :space
  • fixed tests for reva (https://drone.owncloud.com/cs3org/reva/5743/15/6)
    Syntax error (JsonException)
    ...
    Type error: FeatureContext::getJsonDecodedResponse(): Return value must be of type array, null returned (Behat\Testwork\Call\Exception\FatalThrowableError)
    
  • skipped sharing tests for reva

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan
Copy link
Member Author

saw-jan commented Nov 28, 2024

bump PR in reva: cs3org/reva#4976

@saw-jan saw-jan force-pushed the tests/remove-duplicate-steps branch 7 times, most recently from c6386c0 to 2d36f7f Compare December 2, 2024 09:57
@saw-jan saw-jan marked this pull request as ready for review December 2, 2024 09:58
@saw-jan
Copy link
Member Author

saw-jan commented Dec 3, 2024

bump in reva fails: https://drone.owncloud.com/cs3org/reva/5748/11/6
Passing reva build: https://drone.owncloud.com/cs3org/reva/5767

@saw-jan saw-jan marked this pull request as draft December 3, 2024 04:22
@saw-jan saw-jan force-pushed the tests/remove-duplicate-steps branch from 2d36f7f to dee504f Compare December 4, 2024 10:34
@saw-jan saw-jan force-pushed the tests/remove-duplicate-steps branch from a156998 to 084d24f Compare December 5, 2024 10:14
@saw-jan saw-jan marked this pull request as ready for review December 5, 2024 10:16
Copy link

sonarcloud bot commented Dec 5, 2024

}

/**
* @Then user :sharee should have a share :share shared by user :sharer
* @Then user :sharee should have a share :share shared by user :sharer from space :space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to merge the step def as (should|should not) have a share... ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants