Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] change the proftpd image on drone file #111

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[full-ci] change the proftpd image on drone file #111

merged 1 commit into from
Apr 2, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Apr 2, 2024 •
edited
Loading

Description

In this PR, the docker image of proftpd has been changed from hauptmedia/proftpd to driesva/proftpd:1.3.8

Related Issue

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nabim777 nabim777 self-assigned this Apr 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nabim777 nabim777 marked this pull request as ready for review April 2, 2024 06:38
@saw-jan saw-jan requested a review from DeepDiver1975 April 2, 2024 07:06
@saw-jan
Copy link
Member

saw-jan commented Apr 2, 2024

CI is green with the image: https://drone.owncloud.com/owncloud/files_external_ftp/2130/6/3

phil-davis
phil-davis approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pinning it to an exact version is "a good thing" for this, it prevents an "accidental" new release of that from breaking CI.

@DeepDiver1975 DeepDiver1975 merged commit 08f942a into master Apr 2, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the drone/change-proftpd-image branch April 2, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@saw-jan saw-jan Awaiting requested review from saw-jan

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When pulling images CI fails
5 participants
@nabim777 @CLAassistant @saw-jan @phil-davis @DeepDiver1975