Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update or correct default enabledPreviewProviders lists #41294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iasdeoupxe
Copy link
Contributor

@iasdeoupxe iasdeoupxe commented Jul 28, 2024

Description

See this for the current default list:

https://github.com/owncloud/core/blob/v10.15.0/lib/private/PreviewManager.php#L266-L281

and the relevant comments / examples have been ordered the same way. OC\Preview\PDF was dropped from the config.sample.php because it is not in the default enabled list.

Question:

What about these in https://doc.owncloud.com/server/10.14/admin_manual/configuration/files/previews_configuration.html#preview-format-requirements not mentioned anywhere in the updated files:

OC\Preview\AI
OC\Preview\EPS
OC\Preview\PSD
OC\Preview\TTF

Are the docs even correct. few lines in the code we can see this:

https://github.com/owncloud/core/blob/v10.15.0/lib/private/PreviewManager.php#L334-L337

Related Issue

N/A

Motivation and Context

Better documentation

How Has This Been Tested?

No testing, only documentation changes

Screenshots (if appropriate):

N/A

Types of changes

Not sure what to tick here

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

Not sure what to tick here

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2024

CLA assistant check
All committers have signed the CLA.

@iasdeoupxe
Copy link
Contributor Author

Anything required / unclear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants