Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing logout for app password scenario #30597

Merged

Conversation

DeepDiver1975
Copy link
Member

port of #30591

@DeepDiver1975 DeepDiver1975 added this to the development milestone Feb 23, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Feb 23, 2018
@codecov
Copy link

codecov bot commented Feb 23, 2018

Codecov Report

Merging #30597 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30597      +/-   ##
============================================
+ Coverage     61.82%   61.82%   +<.01%     
- Complexity    19051    19052       +1     
============================================
  Files          1089     1089              
  Lines         61442    61445       +3     
============================================
+ Hits          37988    37991       +3     
  Misses        23454    23454
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Session.php 64% <0%> (ø) 144 <0> (ø) ⬇️
lib/private/User/BasicAuthModule.php 96% <100%> (+0.54%) 12 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ef206...da7eb95. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeepDiver1975 DeepDiver1975 merged commit f80eebf into master Feb 24, 2018
@DeepDiver1975 DeepDiver1975 deleted the master-d7ba3f5b7f8878189a3717236a4aa515a80cd279 branch February 26, 2018 08:13
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants