[WIP] Distributed oCIS #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
IljaN
commented
Apr 24, 2020
•
IljaN
commented
- Add document start marker
- Make sharing work (shares.json could not be created on boot)
- Make this work without /etc/hosts entry to ocis-proxy on the host
xoxys
reviewed
Apr 24, 2020
| @@ -0,0 +1,158 @@ | |||
| version: '3.7' | |||
There was a problem hiding this comment.
Just add the document start marker --- as you did in the other YAML file :) and maybe you want to clean up some empty lines at the end of the file. Beside that LGTM
20 tasks
| @@ -0,0 +1,158 @@ | |||
| version: '3.7' | |||
There was a problem hiding this comment.
Suggested change
| version: '3.7' | |
| --- | |
| version: '3.7' |
|
fixes in follow up #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.