Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 404labfr/laravel-impersonate #904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jose123v
Copy link

Closes #903

Using 404labfr/laravel-impersonate in owen-it/laravel-auditing saves the impersonated user instead of the impersonating user

Copy link
Contributor

@willpower232 willpower232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking, one has the ability to provide a custom user resolver in the configuration so this would be better as its own package which relies on owen-it/laravel-auditing and perhaps extends the base user resolver so it can still be used via similar code.

Also if this package starts supporting this impersonation library, it would probably end up supporting other libraries that change the user and that would require extra time and testing from the maintainers.

@cesarreyes3
Copy link

It may take some time until you realize this problem, it would be better to have it

@erikn69
Copy link
Contributor

erikn69 commented May 28, 2024

I have my doubts still,
it could help to get the real executor of the action in the case of that package, and if that package does not exist it should not affect the performance and it seems fine to me

@calebdw
Copy link

calebdw commented Oct 17, 2024

I use both packages and my audits table has both user and impersonator columns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants