Use left join to optimize prune query

owen-it · Jun 26, 2024 · ba451e6 · ba451e6
1 parent db5ed9c
commit ba451e6
Showing 1 changed file with 15 additions and 10 deletions.
diff --git a/src/Drivers/Database.php b/src/Drivers/Database.php
@@ -23,17 +23,22 @@ public function audit(Auditable $model): ?Audit
     public function prune(Auditable $model): bool
     {
         if (($threshold = $model->getAuditThreshold()) > 0) {
-            $class = get_class($model->audits()->getModel());
-            $keyName = (new $class)->getKeyName();
-
-            $idsToKeep = $model->audits()
-                ->select($keyName)
-                ->limit($threshold)
-                ->latest()
-                ->pluck($keyName);
-
+            $auditClass = get_class($model->audits()->getModel());
+            $auditModel = new $auditClass;
+
             return $model->audits()
-                ->whereNotIn($keyName, $idsToKeep)
+                ->leftJoinSub(
+                    $model->audits()->select($auditModel->getKeyName())->limit($threshold)->latest(),
+                    'threshold',
+                    function ($join) use ($auditModel) {
+                        $join->on(
+                            $auditModel->gettable().'.'.$auditModel->getKeyName(),
+                            '=',
+                            'threshold.'.$auditModel->getKeyName()
+                        );
+                    }
+                )
+                ->whereNull('threshold.'.$auditModel->getKeyName())
                 ->delete() > 0;
         }