Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reply in notification deminiaturizing window #392

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Lukakva
Copy link

@Lukakva Lukakva commented Feb 1, 2017

Using reply feature on the notification was deminiaturizing the main window, even if the user was on other application, or even in full screen view.

Things get especially weird when in full screen mode. The window deminiaturizes and covers the screen and then goes into the background.

telegram

Using reply feature on the notification was deminiaturizing the main window, even if the user was on other application, or even on different full screen window.
@overtake
Copy link
Owner

overtake commented Feb 1, 2017

NSUserNotificationActivationTypeReplied will cause crash in 10.8 after receive any message.
// NSUserNotificationActivationTypeReplied NS_AVAILABLE(10_9, NA) = 3,

@antonsteenvoorden
Copy link

is this something configurable? I for one think it's nice that the chat doesn't show after I reply. I think that upon clicking on the notification you should go to the chat (but I believe this dismisses the notification atm).

@overtake
Copy link
Owner

@antonsteenvoorden 🤔

@overtake
Copy link
Owner

@antonsteenvoorden added some changes to this code. now after reply window not appearing

@antonsteenvoorden
Copy link

If I would have wanted to go to the chat, I would cmd tab to it, or just click the telegram icon 😜.
I like that when I hit reply I can continue doing what I was doing.

Something else that is useful tho is to remove the unread messages counter after hitting reply

Im just sharing my opinion, I have no authority.

@antonsteenvoorden
Copy link

Will this open the conversation the notification came from? or just open the application?

@Lukakva
Copy link
Author

Lukakva commented May 16, 2017

@antonsteenvoorden If you just click the notification, it opens the chat.

When you click Reply on the notification, it replies to the chat. The problem was that when you used reply option, it would still open the chat, whereas it would be much better if you could just continue what you were doing (exactly what you said).

@antonsteenvoorden
Copy link

im glad you agree. is the owner still active? since this PR has been around for some time now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants