Create a setting to make stickers look smaller in the chat window (200px -> 40px) #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That one's great, i'll definitely use it if will be merged. |
|
+1 |
|
40x40 is a very smal size. i think 100x100 normal. |
|
Sure, if it works out for you guys! At first I actually wanted to get rid of the stickers completely :) |
|
The size of the stickers could also be a slider perhaps? I can imagine people with large screens might want something in between those 2 sizes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my (real bad) implementation of the issue #154.
It adds an option in the general settings view and its value is a bitwise operation of
2 << 29(the next afterHandleMediaKeysSettings). I wasn't sure why you started shifting from 1 to 2 so I kept it.It also, obviously, isn't the best way to implement that option with the maximum sticker size hard-coded in every
blockSizeassignment, but I suck at Objective-C and am not sure I'd do it better without having a lot of time to spend.The downside is you can't zoom it; I guess the more user-friendly thing would be to make it zoom like an image (perhaps with a full-screen dimmed overlay) on mouse click; the user would still have an option to view all stickers in the stickerset by calling the context menu.
It looks like that:
Feel free to ditch it, just wanted to share with whomever is interested.
Thanks for the awesome project, I've been using it for years. <3
P.S.: I also managed to keep stickers from being shown completely and displaying emoji characters instead, like in the conversations list, but I guess it's not worth a separate pull request. See https://github.com/hatarist/telegram/commit/071fcabebf1fb9b737eabefc5d6ee5bac4399d11