This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Market liquidity decimals #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core into c4-underwater
…ch, add tests for token.burnFrom
Fixed typo.
C4 collateral
C4 comptroller
C4 mothership
C4 underwater
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove the extra off-chain information related to market liquidity in the depth calculation.
Right now, that's simply calling the decimals on
_wethand setting that into amarketLiquidityconstant.But in fact the
_wethparameter should be renamed to be_liquidityQuote, or something along those lines. It isn't necessarily WETH, could be AVAX, or USDC.