This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Inverse multiplex and quanto markets #131
Open
mesozoic-technology
wants to merge
28
commits into
overlay-market:main
Choose a base branch
from
mesozoic-technology:inverse-multiplex-and-quanto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Inverse multiplex and quanto markets #131
mesozoic-technology
wants to merge
28
commits into
overlay-market:main
from
mesozoic-technology:inverse-multiplex-and-quanto
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is dedicated to getting the different flavors of Overlay markets correctly set up.
This will include
I am interested to hear about what adequate testing would be for these.
There are probably unique tests for each one.
But also many of the tests will be the same.
Running these tests will take a good deal of time, now that there will be three markets to interrogate.
One possibility is to configure jobs that can be run in parallel. Perhaps one market type in parallel.
Instead of a plain
brownie test
, a runner can be spun up to dobrownie test tests/markets/collateral/ovl/test_multiplex_inverse_build.py
. And this would run the build tests for the multiplex inverse market, with unique tests for the multiplex inverse included alongside the general tests.Another thing worth considering is hosting an independent test runner with greater specs.
One can get a good deal on various EC2 instances by purchasing them in bulk. Much cheaper than on demand. One buys them for a year at a time, or more, and the price goes down substantially.