Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Error fixes and improvements #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Error fixes and improvements #22

wants to merge 5 commits into from

Conversation

deepsp94
Copy link
Contributor

I'm not done with this branch so not ready to merge yet! Noting down the current status and next steps to keep everyone in loop.

What's done:

  1. Fixed overflow error
  2. TWAP based on an hour, rather than last 6 points (which might not be an hour)

What's left:

  1. Include tolerance parameter for TWAP window
  2. Do not accept duplicate values from brownie. Otherwise/additionally, explore graph implementation for robustness.

@mikeyrf mikeyrf changed the title Error fixes and improvements [WIP] Error fixes and improvements Aug 22, 2021
@deepsp94
Copy link
Contributor Author

deepsp94 commented May 3, 2022

@mikeyrf should we close this for now since Sushi is de-prioritised?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepsp94