Allow graceful inconsistency management by TF when public_ips in reso… #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urceOAPINatServiceRead() is empty In `resourceOAPINatServiceRead()`, access to `public_ips[0]` isn't protected against empty list when the API can return an empty list in some edge cases. When `public_ips` is empty, setting `public_ip_id` to `""` allows the TF refresh to succeed and the TF plan/apply to recreate the Nat Service with the correct `public_ip_id`.
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urceOAPINatServiceRead() is empty
In
resourceOAPINatServiceRead(), access topublic_ips[0]isn't protected against empty list when the API can return an empty list in some edge cases. Whenpublic_ipsis empty, settingpublic_ip_idto""allows the TF refresh to succeed and the TF plan/apply to recreate the Nat Service with the correctpublic_ip_id.