Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful inconsistency management when public_ips in resourceOAPINatServiceRead() is empty #385

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Graceful inconsistency management when public_ips in resourceOAPINatServiceRead() is empty #385

merged 1 commit into from
Oct 16, 2023

Conversation

OursDesCavernes
Copy link
Contributor

Allow graceful inconsistency management by TF when public_ips in resourceOAPINatServiceRead() is empty

In resourceOAPINatServiceRead(), access to public_ips[0] isn't protected against empty list when the API can return an empty list in some edge cases. When public_ips is empty, setting public_ip_id to "" allows the TF refresh to succeed and the TF plan/apply to recreate the Nat Service with the correct public_ip_id.

When the outscale_public_ip used by an outscale_nat_service is deleted, a refresh/plan crashes with the following error:

Stack trace from the terraform-provider-outscale_v0.9.1 plugin:

panic: runtime error: index out of range [0] with length 0

goroutine 195 [running]:
github.com/terraform-providers/terraform-provider-outscale/outscale.resourceOAPINatServiceRead.func1(0xc000a4cad0)
        github.com/terraform-providers/terraform-provider-outscale/outscale/resource_outscale_nat_service.go:182 +0x6f7
github.com/terraform-providers/terraform-provider-outscale/outscale.resourceDataAttrSetter(0xc0002d6f50, 0xc000a998d8)
        github.com/terraform-providers/terraform-provider-outscale/outscale/resource_outscale_vm.go:1334 +0x62
github.com/terraform-providers/terraform-provider-outscale/outscale.resourceOAPINatServiceRead(0xc0002d6f50, {0xff0d80?, 0xc0007b8d58?})
        github.com/terraform-providers/terraform-provider-outscale/outscale/resource_outscale_nat_service.go:161 +0x567
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc0003828c0, 0xc000746a50, {0xff0d80, 0xc0007b8d58})
        github.com/hashicorp/[email protected]/helper/schema/resource.go:470 +0x1aa
github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin.(*GRPCProviderServer).ReadResource(0xc000012068, {0xc000800a20?, 0x4bf046?}, 0xc000800a20)
        github.com/hashicorp/[email protected]/internal/helper/plugin/grpc_provider.go:535 +0x365
github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5._Provider_ReadResource_Handler({0x11a9ee0?, 0xc000012068}, {0x14f63d8, 0xc000b2da70}, 0xc0008009c0, 0x0)
        github.com/hashicorp/[email protected]/internal/tfplugin5/tfplugin5.pb.go:3269 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0001de380, {0x14faae0, 0xc000002000}, 0xc000696300, 0xc0006225a0, 0x1d1d8f0, 0x0)
        google.golang.org/[email protected]/server.go:1194 +0xcbe
google.golang.org/grpc.(*Server).handleStream(0xc0001de380, {0x14faae0, 0xc000002000}, 0xc000696300, 0x0)
        google.golang.org/[email protected]/server.go:1517 +0xa36
google.golang.org/grpc.(*Server).serveStreams.func1.2()
        google.golang.org/[email protected]/server.go:859 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
        google.golang.org/[email protected]/server.go:857 +0x28a

Error: The terraform-provider-outscale_v0.9.1 plugin crashed!

@OursDesCavernes
Allow graceful inconsistency management by TF when public_ips in reso…
f5f0619 
…urceOAPINatServiceRead() is empty

In `resourceOAPINatServiceRead()`, access to `public_ips[0]` isn't protected against empty list when the API can return an empty list in some edge cases.
When `public_ips` is empty, setting `public_ip_id` to `""` allows the TF refresh to succeed and the TF plan/apply to recreate the Nat Service with the correct `public_ip_id`.
@outscale-toa outscale-toa temporarily deployed to test-us-east-2 October 12, 2023 09:46 — with GitHub Actions Inactive
@outscale-toa outscale-toa temporarily deployed to test-eu-west-2 October 12, 2023 09:46 — with GitHub Actions Inactive
@outscale-toa outscale-toa temporarily deployed to test-us-east-2 October 12, 2023 09:46 — with GitHub Actions Inactive
@outscale-toa outscale-toa temporarily deployed to test-eu-west-2 October 12, 2023 09:46 — with GitHub Actions Inactive
@OursDesCavernes
Copy link
Contributor Author

I was also thinking of doing d.setId("") when status is deleted.
Both options are not exclusive, it's good to always protect list index issues.

@outscale-toa outscale-toa merged commit 6c1f2ec into outscale:master Oct 16, 2023
15 of 21 checks passed
@OursDesCavernes OursDesCavernes deleted the fix_empty_public_ip_resp branch October 18, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outscale-toa outscale-toa outscale-toa approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OursDesCavernes @outscale-toa