Add block for primary nic in VM #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-us-east-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
force-pushed
the
fix_secondary_nic_conflict
branch
from
ced97cd to
d94f520
Compare
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
force-pushed
the
fix_secondary_nic_conflict
branch
from
d94f520 to
82e0051
Compare
outscale-toa
had a problem deploying
to
test-us-east-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-us-east-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
force-pushed
the
fix_secondary_nic_conflict
branch
from
82e0051 to
157c932
Compare
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
To avoid confict nic inside VM with link_nic resouces we add a new block 'primary_nic' in VM for only nic with device number 0
outscale-toa
force-pushed
the
fix_secondary_nic_conflict
branch
from
157c932 to
5628f5d
Compare
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-toa
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-mgo
approved these changes
Oct 16, 2023
| networkInterfaces := []oscgo.NicForVmCreation{} | ||
| if nics := d.Get("primary_nic").(*schema.Set).List(); len(nics) > 0 { |
There was a problem hiding this comment.
Can we add an error if both, primary_nic and nics are set please.
|
It seems that this change is not documented at all in terraform documentation. It would be great to align documentation with this feature (https://registry.terraform.io/providers/outscale/outscale/latest/docs/resources/vm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid conflict nic inside VM with link_nic resouces we add a new block 'primary_nic' in VM for only nic with device number 0
Fixed #376