Enable some variables to be externally provided to the computation module #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oavdeev
approved these changes
May 3, 2023
No problem, thanks @oavdeev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the below variables to be provided externally to the computation module. All default to keep existing functionality.
compute_environment_allocation_strategy, Allows alternative allocation strategies which may be better suited depending on the use case, e.g.SPOT_CAPACITY_OPTIMIZEDfor spot environments.compute_environment_additional_security_group_ids(Allow optional security_groups to be passed to batch instance #52)launch_template_image_id, allows for custom AMIs to be provided.No data from
data.tfappeared to be used anywhere in the module. So I also removed this file.