Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] simplify learning rate finder and use log-mean of default and smooth suggestion #1630

Merged
merged 7 commits into from
Aug 14, 2024

Conversation

ourownstory
Copy link
Owner

The LR finder implementation had changed with the transition to using the Lightning implementation. This PR simplifies that implementation and additionally uses the logarithmic mean value of our smooth and the default version.

Copy link

github-actions bot commented Aug 13, 2024

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 0.59734 0.58159 -2.64%
YosemiteTemps RMSE_val 0.88884 0.86935 -2.19%
YosemiteTemps Loss_val 0.00046 0.00044 -4.33%
YosemiteTemps train_loss 0.00126 0.0012 -4.44%
YosemiteTemps reg_loss 0 0 0.0%
YosemiteTemps MAE 0.97461 0.94811 -2.72%
YosemiteTemps RMSE 1.70806 1.66847 -2.32%
YosemiteTemps Loss 0.00126 0.0012 -4.44%
YosemiteTemps time 140.352 137.55 -2.0%
EnergyPriceDaily MAE_val 5.64247 5.42935 -3.78%
EnergyPriceDaily RMSE_val 7.19972 6.88991 -4.3%
EnergyPriceDaily Loss_val 0.02893 0.02655 -8.24% 🎉
EnergyPriceDaily train_loss 0.02957 0.02758 -6.73% 🎉
EnergyPriceDaily reg_loss 0 0 0.0%
EnergyPriceDaily MAE 6.39654 6.15242 -3.82%
EnergyPriceDaily RMSE 8.56207 8.26192 -3.51%
EnergyPriceDaily Loss 0.02936 0.02739 -6.73% 🎉
EnergyPriceDaily time 40.1248 39.8 -0.81%
AirPassengers MAE_val 30.8306 30.081 -2.43%
AirPassengers RMSE_val 31.8167 30.9826 -2.62%
AirPassengers Loss_val 0.01301 0.01234 -5.17% 🎉
AirPassengers train_loss 0.00071 0.00071 -0.86%
AirPassengers reg_loss 0 0 0.0%
AirPassengers MAE 6.88169 6.86203 -0.29%
AirPassengers RMSE 8.92083 8.81789 -1.15%
AirPassengers Loss 0.00076 0.00074 -2.27%
AirPassengers time 9.94 9.73 -2.11%
PeytonManning MAE_val 0.35533 0.35447 -0.24%
PeytonManning RMSE_val 0.50396 0.50324 -0.14%
PeytonManning Loss_val 0.01802 0.01796 -0.32%
PeytonManning train_loss 0.01466 0.01461 -0.3%
PeytonManning reg_loss 0 0 0.0%
PeytonManning MAE 0.34756 0.34738 -0.05%
PeytonManning RMSE 0.4945 0.49347 -0.21%
PeytonManning Loss 0.01465 0.01461 -0.3%
PeytonManning time 25.7366 25.19 -2.12%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

Copy link
Owner Author

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to go

@ourownstory ourownstory merged commit 8330bab into main Aug 14, 2024
8 of 10 checks passed
@ourownstory ourownstory deleted the lr-finder2 branch August 14, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant