-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Make tests deterministic #1600
Conversation
MaiBe-ctrl
commented
Jun 26, 2024
•
edited by ourownstory
Loading
edited by ourownstory
- Add flag to make tests deterministic to better track the metrics and performance of the fitted models.
Model Benchmark
\n
Model training plots\n ## Model Training ### PeytonManning ![](https://asset.cml.dev/a081cefd75c9a4c8e7d9af989beb812ff1a35ee5?cml=svg%2Bxml&cache-bypass=f90bd096-a301-46a9-87d6-e9d6de94338c) ### YosemiteTemps ![](https://asset.cml.dev/3788d85efe7d00c3966556d15d0821e01af3904b?cml=svg%2Bxml&cache-bypass=e840755a-9061-49a2-a15d-2d55285ead57) ### AirPassengers ![](https://asset.cml.dev/94c42fae171cf46d7ad3e4461a1900c92ac07fa7?cml=svg%2Bxml&cache-bypass=2558c24e-1bb4-4e1f-939e-b419141da424) ### EnergyPriceDaily ![](https://asset.cml.dev/cf49507633dca610bf2298513d5de58b58cda6e8?cml=svg%2Bxml&cache-bypass=c9361ac1-5ea5-4973-af15-264e83f280eb) \n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the tests be deterministic now!
I looked through the code and have 3 thoughts:
- What do you think about moving the
deterministic
flag from theNeuralProphet
class init to thetrain
method? AFAIK it only affects training? - Can you please update the tutorial on reproducibility to include this new flag?
- Looks like many of the 'glocal' seasonality tests are removed - is this intentional?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
pyproject.toml
Outdated
@@ -34,6 +34,7 @@ plotly = ">=5.13.1" | |||
kaleido = "0.2.1" # required for plotly static image export | |||
plotly-resampler = { version = ">=0.9.2", optional = true } | |||
livelossplot = { version = ">=0.5.5", optional = true } | |||
lightning-fabric = "^2.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to >=2.0.0