Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fixed ESLint warnings #47

Merged
merged 2 commits into from
Sep 24, 2024
Merged

refactor: fixed ESLint warnings #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c3242
refactor: fixed ESLint warnings
byhlel Sep 23, 2024
23f6db1
refactor: applied suggested fix for ESLINT errors
byhlel Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/miningRulesCore/preProcessing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export const createGroupingMetaData = () => {
const groupMapping = {};
const fileMapping = {};
for (const key in groupingCategories) {
if (!groupingCategories.hasOwnProperty(key)) continue;
groupMapping[key] = {};
}
return {groupMapping, fileMapping};
Expand Down Expand Up @@ -80,6 +81,7 @@ const cleanGroupings = (xmlFile, groupingMetaData) => {
const addToGroupings = (xmlFile, groupingMetaData) => {
const fileID = xmlFile.filePath;
for (const groupingCategoryID in groupingCategories) {
byhlel marked this conversation as resolved.
Show resolved Hide resolved
if (!groupingCategories.hasOwnProperty(groupingCategoryID)) continue;
const values = getValuesForGrouping(xmlFile.xml, groupingCategories[groupingCategoryID]);
for (const valueID of values) {
if (!groupingMetaData.groupMapping[groupingCategoryID][valueID]) {
Expand Down
Loading