HW20 API, CRUD, Resources #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $data = $request->getFormData(); | ||
| $this->advertsService->storeAdvert($data); | ||
| return 'saved'; |
There was a problem hiding this comment.
Можно сразу вернуть сохраненый ресурс
| public function update(StoreAdvertRequest $request, Advert $advert) | ||
| { | ||
| $this->advertsService->updateAdvert($advert, $request->all()); | ||
| return 'Updated'; |
There was a problem hiding this comment.
Можно сразу вернуть обновленый ресурсы это будет по REST
| if($offset) $advert->skip($offset); | ||
|
|
||
| $advert->with('town', 'user', 'division'); | ||
| return $advert->get(['adverts.*']); // ??? |
There was a problem hiding this comment.
Если у вас будут join в запросе, то можете вернуть лишнее данные, это зашита от дурака)
| if ($limit) $advert->take($limit); | ||
| if($offset) $advert->skip($offset); | ||
|
|
||
| $advert->with('town', 'user', 'division'); |
There was a problem hiding this comment.
messages зависимость тоже используете
| @@ -38,6 +38,16 @@ public function paginateList($qty) | |||
| return Advert::with('town', 'user', 'division')->paginate($qty); | |||
| } | |||
|
|
|||
| public function paginateListApi(int $limit, int $offset) | |||
There was a problem hiding this comment.
Я бы предложил переименовать метод в getAdverts(int $limit, int $offset)
a with сделал бы в сервисе,
$adverts = $this->repository->getAdverts
$adverts->load(['town', 'user', 'division', 'messages'])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.