-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/admin/webhooks #628
Feat/admin/webhooks #628
Conversation
ryanhopperlowe
commented
Nov 19, 2024
•
edited
Loading
edited
1fda768
to
0e6e8b3
Compare
The largest chunk of this PR is adding in the |
5a8fa84
to
2bcee12
Compare
control={form.control} | ||
name="token" | ||
label="Token (optional)" | ||
description="Optionally provide a token to add an extra layer of security." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either add more information here or link to docs (if they exist) to explain what this does. Whatever token is set will have to be provided by the webhook provider (i.e. GitHub) in a particular query param or header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I mistakenly assumed the token would be provided in the returned link
meta. I'll update this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this with Will and he decided to hide the token feature entirely until we can talk it out more with Bill/Donnie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the webhook create and edit pages take up the full-screen width. It looks a little weird on my larger monitor. Does it make sense to shrink the width down?
3ecf654
to
ecd5786
Compare
Signed-off-by: Ryan Hopper-Lowe <[email protected]>
ecd5786
to
df6e1a3
Compare
|