fix: unable to start a new thread when tool call in progress (#698)

* fix: unable to start a new thread when tool call in progress - internally indicates chat is no longer running when switching threads Signed-off-by: Ryan Hopper-Lowe <[email protected]> * chore: remove unused agent prop from Agent component Signed-off-by: Ryan Hopper-Lowe <[email protected]> --------- Signed-off-by: Ryan Hopper-Lowe <[email protected]>
otto8-ai · Nov 27, 2024 · a8c7918 · a8c7918
1 parent 0cf1ee7
commit a8c7918
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 24 deletions.
diff --git a/ui/admin/app/components/agent/Agent.tsx b/ui/admin/app/components/agent/Agent.tsx
@@ -17,7 +17,6 @@ import { ScrollArea } from "~/components/ui/scroll-area";
 import { useDebounce } from "~/hooks/useDebounce";
 
 type AgentProps = {
-    agent: AgentType;
     className?: string;
     onRefresh?: (threadId: string | null) => void;
 };

diff --git a/ui/admin/app/components/chat/ChatContext.tsx b/ui/admin/app/components/chat/ChatContext.tsx
@@ -205,6 +205,7 @@ function useMessageSource(threadId?: Nullish<string>) {
 
         return () => {
             source.close();
+            setIsRunning(false);
         };
     }, [threadId, addContent]);
 

diff --git a/ui/admin/app/routes/_auth.agents.$agent.tsx b/ui/admin/app/routes/_auth.agents.$agent.tsx
@@ -65,30 +65,23 @@ export default function ChatAgent() {
 
     return (
         <div className="h-full flex flex-col overflow-hidden relative">
-            <ChatProvider
-                id={agent.id}
-                threadId={threadId}
-                onCreateThreadId={updateThreadId}
-            >
-                <AgentProvider agent={agent}>
-                    <ResizablePanelGroup
-                        direction="horizontal"
-                        className="flex-auto"
+            <ResizablePanelGroup direction="horizontal" className="flex-auto">
+                <ResizablePanel className="">
+                    <AgentProvider agent={agent}>
+                        <Agent onRefresh={updateThreadId} key={agent.id} />
+                    </AgentProvider>
+                </ResizablePanel>
+                <ResizableHandle withHandle />
+                <ResizablePanel>
+                    <ChatProvider
+                        id={agent.id}
+                        threadId={threadId}
+                        onCreateThreadId={updateThreadId}
                     >
-                        <ResizablePanel className="">
-                            <Agent
-                                agent={agent}
-                                onRefresh={updateThreadId}
-                                key={agent.id}
-                            />
-                        </ResizablePanel>
-                        <ResizableHandle withHandle />
-                        <ResizablePanel>
-                            <Chat className="bg-sidebar" />
-                        </ResizablePanel>
-                    </ResizablePanelGroup>
-                </AgentProvider>
-            </ChatProvider>
+                        <Chat className="bg-sidebar" />
+                    </ChatProvider>
+                </ResizablePanel>
+            </ResizablePanelGroup>
         </div>
     );
 }