Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: intents-operator configmap broken when combining IAM roles anywhere & ingress controllers configurations #230

Merged

Conversation

amitlicht
Copy link
Contributor

@amitlicht amitlicht commented Jul 14, 2024

Description

This change fixes a bug when combining IAM roles anywhere configuration with ingress controller configuration, rendering a broken configmap for the intents operator.

Prior to this change, the generated configmap looks as follows:

---
# Source: otterize-infra/charts/otterize-kubernetes/charts/intentsOperator/templates/extended-config-configmap.yaml

apiVersion: v1
kind: ConfigMap
metadata:
  name: intents-operator-config
  namespace: infra
  labels:
    app.kubernetes.io/version: 3.0.13
  annotations:
    app.kubernetes.io/version: 3.0.13
data:
  config.yaml: |-
    aws:
      - account: "..."
        roleARN: ...
        profileARN: ...
        trustAnchorARN: ...
        trustDomain: ...
   ingressControllers:  # <--- this line is missing one space for indentation
      - name: ...
        namespace: ...
        kind: ...

---

This file fails on yaml-to-json conversion due to a missing whitespace in the ingressControllers: line.

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@amitlicht amitlicht force-pushed the amitlicht/fix_iam_rolesanywhere_config_with_ingress_controller branch from b27881a to eb6a700 Compare July 14, 2024 11:27
@amitlicht amitlicht marked this pull request as ready for review July 14, 2024 11:30
@amitlicht amitlicht changed the title Fix: IAM roles anywhere configuration broken when combined with ingress controllers config Bugfix: intents-operator configmap broken when combining IAM roles anywhere & ingress controllers configigurations Jul 14, 2024
@amitlicht amitlicht changed the title Bugfix: intents-operator configmap broken when combining IAM roles anywhere & ingress controllers configigurations Bugfix: intents-operator configmap broken when combining IAM roles anywhere & ingress controllers configurations Jul 14, 2024
@amitlicht amitlicht merged commit 164e1ec into main Jul 14, 2024
10 checks passed
@amitlicht amitlicht deleted the amitlicht/fix_iam_rolesanywhere_config_with_ingress_controller branch July 14, 2024 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant