-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow secrets get permissions for intents operator role, to support reading DB credentials from k8s secrets #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitlicht
force-pushed
the
amitlicht/db_credentials_secrets
branch
from
June 20, 2024 11:13
76a0595
to
2691c97
Compare
…eading DB credentials from k8s secrets
amitlicht
force-pushed
the
amitlicht/db_credentials_secrets
branch
from
June 20, 2024 11:16
2691c97
to
aaf0a54
Compare
evyatarmeged
approved these changes
Jun 20, 2024
amitlicht
force-pushed
the
amitlicht/db_credentials_secrets
branch
3 times, most recently
from
June 20, 2024 11:56
19f05e3
to
3ec03a8
Compare
amitlicht
force-pushed
the
amitlicht/db_credentials_secrets
branch
from
June 20, 2024 11:57
3ec03a8
to
7c0b4f8
Compare
…orkflow that's called from other repositories
amitlicht
force-pushed
the
amitlicht/db_credentials_secrets
branch
from
June 20, 2024 12:59
93ee5d0
to
c27e6b6
Compare
amitlicht
force-pushed
the
amitlicht/db_credentials_secrets
branch
2 times, most recently
from
June 23, 2024 09:30
1ae3efa
to
b5d416e
Compare
amitlicht
force-pushed
the
amitlicht/db_credentials_secrets
branch
from
June 23, 2024 10:29
b5d416e
to
f22acf2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Intents operator PR: otterize/intents-operator#440
Checklist