Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow secrets get permissions for intents operator role, to support reading DB credentials from k8s secrets #218

Merged
merged 18 commits into from
Jun 23, 2024

Conversation

amitlicht
Copy link
Contributor

@amitlicht amitlicht commented Jun 18, 2024

Description

  • Allow secrets get permissions for intents operator role, to support reading DB credentials from k8s secrets
  • Downgrade golang.org/x/exp to v0.0.0-20230124195608-d38c7dcee874 to circumvent an issue with sharing the tests and the operators code in a single go workspace
  • Make the e2e-tests workflow reusable so that it can be called from operator repos, with images loaded from GCR.

References

Intents operator PR: otterize/intents-operator#440

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from 76a0595 to 2691c97 Compare June 20, 2024 11:13
@amitlicht amitlicht marked this pull request as ready for review June 20, 2024 11:13
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from 2691c97 to aaf0a54 Compare June 20, 2024 11:16
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch 3 times, most recently from 19f05e3 to 3ec03a8 Compare June 20, 2024 11:56
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from 3ec03a8 to 7c0b4f8 Compare June 20, 2024 11:57
…orkflow that's called from other repositories
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from 93ee5d0 to c27e6b6 Compare June 20, 2024 12:59
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from b5d416e to f22acf2 Compare June 23, 2024 10:29
@amitlicht amitlicht merged commit 667e964 into main Jun 23, 2024
6 checks passed
@amitlicht amitlicht deleted the amitlicht/db_credentials_secrets branch June 23, 2024 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants