Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to build & release workflow to support E2E tests as release gate and fix some release issues #217

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Changes to build & release workflow to support E2E tests as release gate and fix some release issues #217

merged 8 commits into from
Jun 18, 2024

Conversation

amitlicht
Copy link
Contributor

@amitlicht amitlicht commented Jun 17, 2024 •
edited
Loading

Description

  • Change bump-versions workflow to create git tags after bumping the versions
  • Publish helm charts only on git tags (created in the bump-versions workflow). This is both healthy, to ensure we have a tagged record of published versions, and solves a bug where the publish workflow ran on main before the bump-versions workflow, which led to overriding of the previous published helm-chart version.
  • Merge E2E tests into a single workflow
  • Require e2e tests before publishing helm charts
  • Bump github action versions for many gh action dependencies

@amitlicht amitlicht force-pushed the amitlicht/build_release_workflow branch from 22c719a to 5825a72 Compare June 17, 2024 11:40
@amitlicht amitlicht force-pushed the amitlicht/build_release_workflow branch from 5825a72 to d349ab2 Compare June 17, 2024 11:41
@amitlicht amitlicht changed the title New helm-charts release workflow to support E2E tests as release gate & fix some release bugs Create git tags after bumping chart versions and publish helm charts only on git tags (rather than on main) Jun 17, 2024
@amitlicht amitlicht marked this pull request as ready for review June 17, 2024 11:45
@amitlicht amitlicht changed the title Create git tags after bumping chart versions and publish helm charts only on git tags (rather than on main) Changes to build & release workflow to support E2E tests as release gate and fix some release issues Jun 17, 2024
@amitlicht amitlicht requested review from omris94 and removed request for evyatarmeged June 18, 2024 10:22
@amitlicht amitlicht merged commit efbf85d into main Jun 18, 2024
5 checks passed
@amitlicht amitlicht deleted the amitlicht/build_release_workflow branch June 18, 2024 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@omris94 omris94 omris94 approved these changes

Assignees
No one assigned
Labels
run-azure-e2e-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitlicht @omris94