Refactor vocations: Reload, extracted into tfs::game::vocations namespace and code improvements #4807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
tfs::game::vocations
namespace to organize vocation-related logic in a more structured way.std::shared_ptr
for improved memory management and safety.load_from_xml(...)
to load vocation data from an XML file, with an option to reload existing data.find_by_id(uint16_t id)
find_by_name(std::string_view name)
find_by_promoted_id(uint16_t id)
Note: It is not possible to delete a vocation at runtime; only to modify or add new ones.
Before reload.
After changed and reload.
Usage