Add missing lua gc in DB Insert (#4596)

otland · Dec 13, 2023 · 0f606ee · 0f606ee
1 parent 40bf60a
commit 0f606ee
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/luascript.cpp b/src/luascript.cpp
@@ -2206,6 +2206,7 @@ void LuaScriptInterface::registerFunctions()
 
  // DB Insert
  registerClass("DBInsert", "", LuaScriptInterface::luaDBInsertCreate);
+ registerMetaMethod("DBInsert", "__gc", LuaScriptInterface::luaDBInsertDelete);
 
  registerMethod("DBInsert", "addRow", LuaScriptInterface::luaDBInsertAddRow);
  registerMethod("DBInsert", "execute", LuaScriptInterface::luaDBInsertExecute);
@@ -4445,6 +4446,16 @@ int LuaScriptInterface::luaDBInsertExecute(lua_State* L)
  return 1;
 }
 
+int LuaScriptInterface::luaDBInsertDelete(lua_State* L)
+{
+ DBInsert** insertPtr = getRawUserdata<DBInsert>(L, 1);
+ if (insertPtr && *insertPtr) {
+ delete *insertPtr;
+ *insertPtr = nullptr;
+ }
+ return 0;
+}
+
 // DB Transaction
 int LuaScriptInterface::luaDBTransactionCreate(lua_State* L)
 {

diff --git a/src/luascript.h b/src/luascript.h
@@ -503,6 +503,7 @@ class LuaScriptInterface
  static int luaDBInsertCreate(lua_State* L);
  static int luaDBInsertAddRow(lua_State* L);
  static int luaDBInsertExecute(lua_State* L);
+ static int luaDBInsertDelete(lua_State* L);
 
  // DB Transaction
  static int luaDBTransactionCreate(lua_State* L);