feat: add support for named exports #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieDanielson
commented
May 31, 2024
| @@ -4,7 +4,9 @@ | |||
| "description": "Safe(r) monkeypatching for JavaScript.", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "standard && tap test/*.tap.js --coverage" | |||
| "test": "npm run test:cjs && npm run test:mjs", | |||
There was a problem hiding this comment.
I can see this being condensed into a single line for testing instead of separating out the esm named export test, open to suggestion.
JamieDanielson
commented
May 31, 2024
| @@ -23,6 +25,6 @@ | |||
| "devDependencies": { | |||
| "sinon": "^7.2.2", | |||
| "standard": "^12.0.1", | |||
| "tap": "^12.1.1" | |||
| "tap": "15.2" | |||
JamieDanielson
commented
May 31, 2024
| enumerable: false | ||
| }) | ||
|
|
||
| test('should wrap safely with named export in esm', function (t) { |
There was a problem hiding this comment.
This is lifted from the wrap.tap.js test, with the main difference being the use of the named import. I wasn't sure whether to add tests for each method or if this is sufficient.
JamieDanielson
commented
May 31, 2024
| 'wrapped unenumerable property is still unenumerable') | ||
| }) | ||
|
|
||
| test('should properly import each named export', function (t) { |
There was a problem hiding this comment.
This second test just confirms the named imports successfully imported. It may not be necessary, open to feedback.
|
Since this is a larger change because of the test updates, I'm more than happy to reduce this to only add the named exports and not make adjustments to tests and updating the tap package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
karmawith wpt runner in user-interaction open-telemetry/opentelemetry-js-contrib#2005Short description of the changes
There is some explanation here of the problems we were running into while trying to update our tests to use a new test runner. It seems that this will be resolved by providing named exports, which may help other folks using ESM as well.
@std/esmthat didn't work as expected in tests. The latest version has some other changes so I opted for 15.2 to minimize overall changes while still allowing this test to work.