Allow reservation time to be extended #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starcraft66
commented
Jan 24, 2024
| @@ -43,7 +43,8 @@ defmodule Lanpartyseating.ReservationLogic do | |||
| "new_reservation", | |||
| %{ | |||
| station_number: station_number, | |||
There was a problem hiding this comment.
Sneaking in a little change unrelated to the PR to the non-finalized contract between the server and the desktop client. We will tell the client the start and end times of the reservation to allow it to keep track of session expiry internally to make it more robust against lag switching.
starcraft66
commented
Jan 24, 2024
| Endpoint.broadcast!( | ||
| "desktop:all", | ||
| "extend_reservation", | ||
| %{ |
There was a problem hiding this comment.
Same contract as above to notify the desktop client that the session has been extended.
starcraft66
commented
Jan 24, 2024
| @@ -74,11 +74,29 @@ defmodule CancellationModalComponent do | |||
| "%H:%M" | |||
| ) %> *REPLACE WITH COUNTDOWN*</b> | |||
| </p> | |||
| <p class="py-4">Enter a reason for canceling the reservation</p> | |||
| <form method="dialog"> | |||
| <button class="btn btn-sm btn-circle btn-ghost absolute right-2 top-2">✕</button> | |||
| </form> | |||
|
|
|||
There was a problem hiding this comment.
Really not my proudest UI work but it's good enough to get this feature started. I'm hoping @luxor37 will have the willpower to redesign this into something nicer 
luxor37
approved these changes
Feb 13, 2024
berbiche
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, we want to give gamers additional time on their reservation to finish a match for example. This PR adds a (pretty terrible) user interface to the "Cancellation" page that allows an operator to extend a session by a set amount of minutes as well as cancelling it. The cancellation page should probably be renamed to something more generic like "station management" to reflect this change in functionality.
The new cancellation modal with these changes:
