This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Use correct image name on Windows flashall.bat #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,6 +107,7 @@ IMAGE_CMD_toflash () { | |||
|
|
|||
| # update image name inside flashall.sh | |||
| sed -e "s/^IMAGE_NAME=.\+$/IMAGE_NAME=\"${IMAGE_BASENAME}\"/" -i ${WORKDIR}/toFlash/flashall.sh | |||
| sed -e "s/^IMAGE_NAME=.\+$/IMAGE_NAME=${IMAGE_BASENAME}/" -i ${WORKDIR}/toFlash/flashall.bat | |||
There was a problem hiding this comment.
yes, should be
sed -e "s/^set IMAGE_NAME=.\+$/set IMAGE_NAME=${IMAGE_BASENAME}/" -i ${WORKDIR}/toFlash/flashall.bat
There was a problem hiding this comment.
OK thanks, stupid copy-paste error. I'll fix it and test this on Windows once the builds finishes.
|
edison build (build job #1147) of 1st CI cycle of this PR did fail with permissions msg and that was my fault, sorry for trouble. A new worker-21 that I was adding, went online too early. I am not retriggering yet, based on comments this may get some more changes. |
jlaako
force-pushed
the
edison-updates
branch
2 times, most recently
from
0c357f0 to
c82e514
Compare
The Windows flashall.bat was unmaintained and had old image name. Modify the flashall.bat to accept image name as argument and also modify the flashall.bat when producing toflash-tarball. Fixes: ostro-os issue ostroproject#62 Signed-off-by: Jussi Laako <[email protected]>
|
looks good to me 👍 |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows flashall.bat was unmaintained and had old image name. Modify
the flashall.bat to accept image name as argument and also modify the
flashall.bat when producing toflash-tarball.
Fixes: ostroproject/ostro-os#62
Signed-off-by: Jussi Laako [email protected]