Switch to external composefs #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
use-external-composefs
branch
2 times, most recently
from
fde20ee to
d61ebc9
Compare
ericcurtin
approved these changes
Dec 4, 2023
jlebon
approved these changes
Dec 4, 2023
|
I've belatedly realized that not having composefs shipped in current c9s is going to make this more logistically complicated. I think that will likely happen, but hard to say when. |
|
Yeah, for practical reason, maybe hold off on this a bit. |
cgwalters
force-pushed
the
use-external-composefs
branch
2 times, most recently
from
9a8ddce to
abe971b
Compare
|
OK composefs is in c9s, rebased 🏄 |
cgwalters
force-pushed
the
use-external-composefs
branch
from
abe971b to
67e0cad
Compare
alexlarsson
approved these changes
Feb 16, 2024
|
Yeah, various CI failures because our build/runtime deps come from packaging and that breaks when dropping in new binaries. I did https://src.fedoraproject.org/rpms/ostree/c/b64d73f3718115cb9d6926275e21f5b16c3f14f9?branch=rawhide as one fix. |
cgwalters
force-pushed
the
use-external-composefs
branch
from
67e0cad to
7c71fcd
Compare
cgwalters
force-pushed
the
use-external-composefs
branch
2 times, most recently
from
9685989 to
3e2d44e
Compare
|
Ah, this needs coreos/fedora-coreos-config#2900 at least |
Previously this was masked by us shipping composefs vendored.
Right now there's skew where we don't have composefs-devel in the buildroot. In general this optimization isn't worth it.
Since there's now a stable shared library, let's use it.
cgwalters
force-pushed
the
use-external-composefs
branch
from
3e2d44e to
eb54a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's now a stable shared library, let's use it.