Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Drop bare-user on tmpfs negative test #3107

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

cgwalters
Copy link
Member

@jlebon
Copy link
Member

jlebon commented Dec 4, 2023

Why not keep the test but verify that creating a bare-user repo on tmpfs doesn't error out now?

@cgwalters
Copy link
Member Author

Why not keep the test but verify that creating a bare-user repo on tmpfs doesn't error out now?

Well, in theory longer term we want to be able to run our tests across multiple distributions.

@jlebon
Copy link
Member

jlebon commented Dec 4, 2023

Ahhh, is support for it gated behind a config? We could grep for it and skip it if it's not on.

@cgwalters
Copy link
Member Author

Ahhh, is support for it gated behind a config?

I don't think so, see the linked commit. It changed to unconditional support.

Is it really worth keeping our CI broken over this?

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, is support for it gated behind a config?

I don't think so, see the linked commit. It changed to unconditional support.

In that case, I don't understand #3107 (comment).

I'm just pointing out that this test can trivially be turned from a negative to a positive test.

Is it really worth keeping our CI broken over this?

Not really. I hadn't realized this was blocking CI. Feel free to merge!

@cgwalters
Copy link
Member Author

I'm just pointing out that this test can trivially be turned from a negative to a positive test.

Not if we want to run the tests on c9s, where that commit isn't backported right?

@cgwalters cgwalters merged commit 09e32d6 into ostreedev:main Dec 4, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants