Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boot/dracut: Add erofs and overlayfs kernel modules #3053

Merged
merged 1 commit into from
Sep 21, 2023
Merged

boot/dracut: Add erofs and overlayfs kernel modules #3053

merged 1 commit into from
Sep 21, 2023

Conversation

ericcurtin
Copy link
Collaborator

These kernel modules are required for composefs usage in the initramfs.

The composefs use-case as of today uses an overlayfs on top of a erofs.

@ericcurtin
Copy link
Collaborator Author

This is a forked version of #3048

@cgwalters cgwalters force-pushed the add_overlay_and_erofs_to_initrd branch from 6879176 to 38e463f Compare September 20, 2023 23:08
@cgwalters cgwalters added the area/prepare-root Issue relates to ostree-prepare-root label Sep 20, 2023
@cgwalters cgwalters changed the title Add erofs and overlayfs kernel modules to initramfs boot/dracut: Add erofs and overlayfs kernel modules Sep 20, 2023
cgwalters
cgwalters approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor procedural note: Please add a "topic prefix" by default to the git commit message. In this case I chose boot/dracut:

We aim to roughly follow Linux kernel conventions in this.

@cgwalters cgwalters enabled auto-merge September 20, 2023 23:14
@ericcurtin @jlebon
boot/dracut: Add erofs and overlayfs kernel modules
cecb59d 
These kernel modules are required for composefs usage in the initramfs.

The composefs use-case as of today uses an overlayfs on top of EROFS.
@jlebon jlebon force-pushed the add_overlay_and_erofs_to_initrd branch from 38e463f to cecb59d Compare September 21, 2023 16:03
@github-actions github-actions bot removed the area/prepare-root Issue relates to ostree-prepare-root label Sep 21, 2023
@jlebon
Copy link
Member

jlebon commented Sep 21, 2023

(Since CI failed anyway, I took the opportunity to fix a typo in the commit message (drauct) and repush to retrigger CI.)

@cgwalters cgwalters merged commit 46b7821 into ostreedev:main Sep 21, 2023
21 checks passed
@ericcurtin
Copy link
Collaborator Author

@cgwalters and @jlebon thanks guys

@ericcurtin ericcurtin deleted the add_overlay_and_erofs_to_initrd branch September 21, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericcurtin @jlebon @cgwalters