finalize: Add RequiresMountsFor=/boot too #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://bugzilla.redhat.com/show_bug.cgi?id=1827712 some OpenShift CI is seeing `/boot` being unmounted before `ostree-finalize-staged.service` runs or completes. We finally tracked this down to a bug elsewhere, but I think we should add this because it clearly shows our requirements.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, rfairley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
if i have mounted boot but in readonly mode? does requires mounts for check also that path is writable ? |
This doesn't affect readonly state. See #1767 for that. |
|
@cgwalters thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://bugzilla.redhat.com/show_bug.cgi?id=1827712
some OpenShift CI is seeing
/bootbeing unmounted beforeostree-finalize-staged.serviceruns or completes.We finally tracked this down to a bug elsewhere, but
I think we should add this because it clearly shows
our requirements.