This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
unencapsulate: Handle legacy docker MIME type #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original design of the skopeo proxy, the idea is that it shields us from the legacy Docker formats, converting everything to OCI. That has worked - except it turns out in the case of pulling a docker-formatted image from `containers-storage`, the proxy code fails to convert the layer types. In this case, it's easy to handle here; we only need to care about the uncompressed version in this case.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original design of the skopeo proxy, the idea is that it shields us from the legacy Docker formats, converting everything to OCI.
That has worked - except it turns out in the case of pulling a docker-formatted image from
containers-storage, the proxy code fails to convert the layer types.In this case, it's easy to handle here; we only need to care about the uncompressed version in this case.