Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LvmThin #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support LvmThin #45

wants to merge 2 commits into from

Conversation

jclab-joseph
Copy link

@jclab-joseph jclab-joseph commented Oct 5, 2022 •
edited
Loading

Fixes #27 #44

On my machine local-lvm to local-lvm and local-lvm to zfs works.

wdoekes
wdoekes requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@wdoekes wdoekes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this changeset.

There are some references to ZFS in the new ProxmoxStorageLvmThin (comments). Those look like copy-paste remnants.

Also, how do you configure lvm(thin)? Does the documentation/sample config need to be updated?

(And, please observe 80char max line length.)

@zombah
Copy link

zombah commented Oct 25, 2022

Thanks for this PR, i tested it with folder to local-lvm and it works as expected if
lvm group have name pve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdoekes wdoekes wdoekes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFE: lvmthin storage support
3 participants
@jclab-joseph @zombah @wdoekes