-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc2GitHub CWE-665 #573
Doc2GitHub CWE-665 #573
Conversation
Signed-off-by: Helge Wehder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one comment for a missing "the" on line 22. Once this is added I will approve!
The `noncompliant01.py` code is simulating the spawning of processes with the different access rights. | ||
The `Session(object)` class simulates access control via `User(Enum)thread` defining a `User` object to be either `GUEST = 1` (default) or `ADMIN = 2`. The `set_user()` method changes access level and `set_user_as_guest()` is to reset access. | ||
|
||
In `SessionPool()` we spawn tasks and access control in following order: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably say "in the following order" rather than "in following order"
fixed typo Signed-off-by: myteron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
As part of #531 , adding documentation to CWE-665