Add invitation to open issues #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an invitation to open issues to the regexp summary doc Signed-off-by: Daniel Appelquist <[email protected]>
ctcpip
approved these changes
Jun 4, 2024
Co-authored-by: Chris de Almeida <[email protected]> Signed-off-by: Daniel Appelquist <[email protected]>
| @@ -129,4 +129,10 @@ In addition, ensure your regex is not vulnerable to a Regular Expression Denial | |||
|
|
|||
| For detailed rationale, along with other information such as contributor credits, see [Correctly Using Regular Expressions for Secure Input Validation - Rationale](./Correctly-Using-Regular-Expressions-Rationale). | |||
|
|
|||
| ## Contributions and Corrections Welcome | |||
|
|
|||
| If you have any additions, changes, or corrections you'd like to suggest, please [open an issue](https://github.com/ossf/wg-best-practices-os-developers/issues). We appreciate your contributions! | |||
There was a problem hiding this comment.
I like the basic idea! However, instead of only recommending issues, we should recommend creating issues or pull requests; we shouldn't require unnecessary steps. If there's a simple typo, I'd want them to just create a PR. E.g., something like this:
If you have any additions, changes, or corrections you'd like to suggest, please open an issue or create a pull request. We appreciate your contributions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an invitation to open issues to the regexp summary doc