Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for Python script #38

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

luigigubello
Copy link
Contributor

@luigigubello luigigubello commented Sep 18, 2023

This PR adds a Dockerfile for the Python script validator-and-generator.py. This should partially solve #33

Signed-off-by: Luigi Gubello <[email protected]>
@luigigubello luigigubello added the enhancement New feature or request label Sep 18, 2023
@luigigubello
Copy link
Contributor Author

@eddie-knight can you try to run the script now?

@eddie-knight
Copy link
Contributor

Testing this now.

Regarding the documentation update, may I recommend that we change to utilizing the GitHub vulnerability reporting tooling for this repo? (security tab at the top)

@eddie-knight
Copy link
Contributor

The containerization works as intended! I didn't get very far in testing the functionality, but that can be improved in follow-up PRs if needed.
Screen Shot 2023-09-18 at 5 37 25 AM

Copy link
Contributor

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only request before merge is that we do the full reorganization (file-creation and file-deletion) in the same PR. Currently this will result in two copies of the python code in the main branch.

Signed-off-by: Luigi Gubello <[email protected]>
@luigigubello
Copy link
Contributor Author

Currently this will result in two copies of the python code in the main branch.

Oh right, this was definitely not intended.

@luigigubello
Copy link
Contributor Author

Regarding the documentation update, may I recommend that we change to utilizing the GitHub vulnerability reporting tooling for this repo? (security tab at the top)

Yes, good point. We have the private vulnerability reporting enabled, I will also add a SECURITY.md in a different PR.

Signed-off-by: Luigi Gubello <[email protected]>
@eddie-knight eddie-knight merged commit 75e4a1e into master Sep 22, 2023
3 checks passed
@eddie-knight eddie-knight deleted the luigigubello/dockerfile-for-python branch September 29, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants