Hamilton8415/ehpto switchlossfix

[hamilton8415]

This merge brings changes to the electro-hydraulic PTO plugin into main and includes a number of changes to improve the match between the plugins behavior and the bench-test measurements

[andermi]

ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata_exp:='2022.12.21T15.44.24_VentedSpring.exp' test_inputdata_tst:='2022.12.21T15.44.24_VentedSpring.tst'

[andermi]

I didn't like how you have to specify both exp and tst... so, now I just have you enter the basename once and it will do the .exp and .tst for you

[andermi]

oops... I broke something stupid with the CI version of experiment_comparison. I'll fix it.

[andermi]

I think I found a much easier way to write the args... 🤦‍♂️

[hamilton8415]

I never doubted you, I'll give it a run-through whenever it's set.

[andermi]

I still need to implement it. I'll let you know when it's done :)

[andermi]

ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata:='2022.12.21T15.44.24_VentedSpring'

or,

ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata:='2022.12.21T15.44.24_VentedSpring.exp'

or,

ros2 launch buoy_tests experiment_comparison_select.launch.py manual:=True test_inputdata:='/path/to/2022.12.21T15.44.24_VentedSpring.exp'

it will always look in buoy_tests/test_inputdata/ for the name of the test you specified... it will ignore your path. and it will also ignore the .exp and .tst file extensions

[andermi]

fixed the absement tests and added some comments for what I did in the _select launch file... The only test not passing is the experiment_comparison now. Need to approve the .tst I think

[andermi]

LGTM!

[andermi]

nice job remembering the CI hehe