-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latent Data on ROS 2 #157
Latent Data on ROS 2 #157
Conversation
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
… with non-pointer in ECM Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
…mode Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
@hamilton8415 do you want hydraulic_motor_loss and relief_valve_loss to be in the latent data? If so, would you mind handling computing those? |
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Sample message:
|
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Great start, I'm catching up here and thought I'd start by brainstorming the items that I can think of, although I think you have most of this in here already, so in many cases my list here is already in the LatentData struct/msg. There are decisions to make about presenting forces, or instantaneous power losses. I think the latter may be more useful for many purposes, I'm not 100% sure... It would be really something to present a total power balance in real time, power in from the waves and out into all the losses (and hopefully the battery), but it's ambitious, a few items may be hard to compute. In any event, I can certainly take the electro-hydraulic and wave-body items to implement/check and will make a branch to work in... Incident Waves
Free Surface Hydrodynamics (these force/moments are a little tricky b/c the coordinate system they are expressed in can be ambiguous)
Hydrodynamic Drag Losses (This may be tricky or impossible b/c we are using an existing Gazebo plugin, so maybe skip for now)
Piston Behaviors
ElectroHydraulic PTO
Tether (May be impossible to divine)
Air spring
|
@hamilton8415 edited your list with checkboxes |
added mechanical/volumetric efficiencies |
I added them to latent_data in the same form as you apply the wrench
|
We have a force/torque sensor at the universal joint between the buoy and the pto. It provides 6dof force/torque, but we are only using force.z to act as the load_cell. Do we want to report all the other values in latent_data? |
we could also add more force/torque sensors anywhere we'd like for extra info |
…n spring Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Thanks, ros2 topic echo /latent_data now streaming data... |
Adjusting reported Latent Data fields for electrohydraulic PTO
@hamilton8415 next step is power for WaveBodyInteractions? |
Yeah, I made branches to get started on that, but am still thinking about it some. We might not want to get too crazy, in that case there's energy coming and going from potential/kinetic energies, so things aren't going to line up so well as the quasi-static ehpto, so it'll be interesting maybe, but I'm not thinking we want to pursue an entire energy balance checking for the whole system, since we don't also have easy ways to incorporate viscous drag, etc. So basically, I think we should go ahead and include potentially interesting quantities throughout, and call it done. :) |
* added wave_body total forces Signed-off-by: Michael Anderson <[email protected]> * added buoy pose and twist to latent data Signed-off-by: Michael Anderson <[email protected]> * added pose/twist to operator== for latent data Signed-off-by: Michael Anderson <[email protected]> * init pose/twist Signed-off-by: Michael Anderson <[email protected]> * linters Signed-off-by: Michael Anderson <[email protected]> --------- Signed-off-by: Michael Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress.
needs osrf/mbari_wec_utils#54
publish latent data (modeled but not directly measured) on ROS 2 including: