WIP adding *untested* implementation of the weights #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @nhejazi and #12
This implements the
weights
option throughout the package for the two availablebin_estimator
s speedglm and glm.The implementation is untested and has not been debugged. No test cases have been written yet.
The most difficult and potentially error prone use case is when pooling bin hazards into a single regression (`pool=TRUE'). While the weights option should still work in that case, it is a more difficult implementation, and hence, more susceptible to errors:
https://github.com/osofr/condensier/blob/weights/R/BinOutModelClass.R#L24-L43