Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP adding *untested* implementation of the weights #14

Closed
wants to merge 1 commit into from
Closed

Conversation

osofr
Copy link
Owner

@osofr osofr commented Dec 9, 2017

Per @nhejazi and #12

  • This implements the weights option throughout the package for the two available bin_estimators speedglm and glm.

  • The implementation is untested and has not been debugged. No test cases have been written yet.

  • The most difficult and potentially error prone use case is when pooling bin hazards into a single regression (`pool=TRUE'). While the weights option should still work in that case, it is a more difficult implementation, and hence, more susceptible to errors:

https://github.com/osofr/condensier/blob/weights/R/BinOutModelClass.R#L24-L43

@osofr osofr mentioned this pull request Dec 9, 2017
@osofr
Copy link
Owner Author

osofr commented Dec 13, 2017

Closing because #12

@osofr osofr closed this Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant