-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset group #34
Merged
Merged
Asset group #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crnbarr93
reviewed
Oct 10, 2024
crnbarr93
reviewed
Oct 11, 2024
crnbarr93
reviewed
Oct 11, 2024
crnbarr93
approved these changes
Oct 11, 2024
crnbarr93
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments otherwise LGTM!
nice catches, will fix them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce concept of
scope
for limiter and upcoming rebalancing incentivescope
can be eitherdenom
orasset_group
which can practically represent source chain or bridge. This is what changed in registering limiter:scope
can be prefixed with eitherdenom::
orasset_group::
to differentiate the scope variant.In order to specify an
asset_group
as scope, it creating new group is requriedit can also be removed, and the associated limiters will we removed along with it
mark_corrupted_assets
&unmark_corrupted_assets
also changed tomark_corrupted_scopes
&unmark_corrupted_scopes
The assets that are within the corrupted scopes will be removed from the pool when the amount reaches 0 as before. The reference to the specific asset that is corrupted and reaches 0 will also be removed from
asset_group
. Once asset group emptied, it is also automatically removed.