-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebalancing incentive calculation #33
Conversation
78ad42c
to
d5fe090
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a potential small comment change. Will need to evaluate how these functions are implemented in the rest of the contract but it looks like that'll be a separate PR.
/// $$ | ||
/// C(b) = | ||
/// \begin{cases} | ||
/// \left(\frac{b - \phi_l}{\phi_l}\right)^2 & \text{if } 0 \leq b \lt \phi_l \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// \left(\frac{b - \phi_l}{\phi_l}\right)^2 & \text{if } 0 \leq b \lt \phi_l \\ | |
/// \left(\frac{\phi_l - b}{\phi_l}\right)^2 & \text{if } 0 \leq b \lt \phi_l \\ |
Is this the correct way? The formula doesn't match the implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will close this PR as the changes are already included in #36 |
All calculations for rebalancing incentive mechanism, precision loss are handled.
More info on the mechanism https://hackmd.io/_c9N1wV5RZ-VlpstKUaKjA