Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roman/data 187 sqs datadog poc #8333

Closed
wants to merge 3 commits into from
Closed

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 30, 2024

Closes: #XXX

What is the purpose of the change

Ref:

Note that I ended up not needing the logic in the SDK fork since it was missing headers anyways (the server is exposed comet side)

Logic is ported over from the SQS POC: osmosis-labs/sqs#250. The instructions to start this up are exactly the same as in the SQS POC PR.

Success Trace

@p0mvn p0mvn changed the base branch from main to v25.x May 30, 2024 22:19
@github-actions github-actions bot added C:x/epochs C:app-wiring Changes to the app folder labels May 30, 2024
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

Copy link
Contributor

github-actions bot commented Jun 8, 2024

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jun 8, 2024
@github-actions github-actions bot removed the Stale label Jun 11, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jun 20, 2024
Comment on lines +1053 to +1068
func initOTELTracer(ctx context.Context, res *resource.Resource) (*sdktrace.TracerProvider, error) {
exporter, err := otlptracegrpc.New(ctx, otlptracegrpc.WithInsecure())
if err != nil {
return nil, err
}

tp := sdktrace.NewTracerProvider(
sdktrace.WithBatcher(exporter),
sdktrace.WithResource(res),
)

otel.SetTracerProvider(tp)
otel.SetTextMapPropagator(propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{}))

return tp, nil
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here


// resource.WithContainer() adds container.id which the agent will leverage to fetch container tags via the tagger.
res, err := resource.New(ctx, resource.WithContainer(),
resource.WithAttributes(semconv.ServiceNameKey.String("osmosis")),
Copy link
Contributor

@alessandrolomanto alessandrolomanto Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace osmosis with a variable. The environment variable DD_SERVICE=osmosis-fn does not override it

@github-actions github-actions bot removed the Stale label Jun 21, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jun 30, 2024
@p0mvn p0mvn removed the Stale label Jun 30, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jul 9, 2024
@github-actions github-actions bot closed this Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:x/epochs Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants