-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roman/data 187 sqs datadog poc #8333
Conversation
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
func initOTELTracer(ctx context.Context, res *resource.Resource) (*sdktrace.TracerProvider, error) { | ||
exporter, err := otlptracegrpc.New(ctx, otlptracegrpc.WithInsecure()) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
tp := sdktrace.NewTracerProvider( | ||
sdktrace.WithBatcher(exporter), | ||
sdktrace.WithResource(res), | ||
) | ||
|
||
otel.SetTracerProvider(tp) | ||
otel.SetTextMapPropagator(propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{})) | ||
|
||
return tp, nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
|
||
// resource.WithContainer() adds container.id which the agent will leverage to fetch container tags via the tagger. | ||
res, err := resource.New(ctx, resource.WithContainer(), | ||
resource.WithAttributes(semconv.ServiceNameKey.String("osmosis")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to replace osmosis
with a variable. The environment variable DD_SERVICE=osmosis-fn
does not override it
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Closes: #XXX
What is the purpose of the change
Ref:
Note that I ended up not needing the logic in the SDK fork since it was missing headers anyways (the server is exposed comet side)
Logic is ported over from the SQS POC: osmosis-labs/sqs#250. The instructions to start this up are exactly the same as in the SQS POC PR.
Success Trace